feat: update Tabs component with count summary#598
Open
kedar-hargude wants to merge 13 commits intoRealDevSquad:developfrom
Open
feat: update Tabs component with count summary#598kedar-hargude wants to merge 13 commits intoRealDevSquad:developfrom
kedar-hargude wants to merge 13 commits intoRealDevSquad:developfrom
Conversation
|
@kedar-hargude is attempting to deploy a commit to the RDS-Team Team on Vercel. A member of the Team first needs to authorize it. |
kedar-hargude
force-pushed
the
feat/status-tasks-tabs
branch
from
8f90bdc to
a145cfb
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
harshith-venkatesh
suggested changes
Jun 26, 2023
| background: white; | ||
| border: none; | ||
| padding: 12px 8px 8px; | ||
| font-size: 0.8em; |
Contributor
There was a problem hiding this comment.
Could you check whether em suits better or rem here
Author
There was a problem hiding this comment.
Checked it for all dimensions. There is no visible change for such a short value.
src/components/Tabs/Tabs.module.scss
Outdated
| font-size: 0.8em; | ||
| border: none; | ||
| cursor: pointer; | ||
| color: #a1a5b7; |
Contributor
There was a problem hiding this comment.
Would it be better to create variable name for color?
Author
There was a problem hiding this comment.
I didn't use a variable name since it's being used only once. But if it's better, then I'll surely use it.
kedar-hargude
force-pushed
the
feat/status-tasks-tabs
branch
from
e03a416 to
a8f0d13
Compare
RitikJaiswal75
suggested changes
Jun 30, 2023
Contributor
RitikJaiswal75
left a comment
RitikJaiswal75
left a comment
There was a problem hiding this comment.
Please provide test coverage in PR description
kedar-hargude
force-pushed
the
feat/status-tasks-tabs
branch
from
a8f0d13 to
013651c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
update the Tabs component with the count summary of each Tab
Description:
The Tabs component doesn't show the summary count of the number of tasks for each tab.
Updating the component, upon using feature flag, would show the correct count to the viewer, alongside the tab name and change the design of the tab according to the figma file.
Anthing you would like to inform the reviewer about:
Dev Tested:
Images/video of the change:
Test Coverage
#430